# MarkupsToModel : should we replace SetCurveIsLoop by SetCurveIsClosed?

**URL:** <https://discourse.slicer.org/t/markupstomodel-should-we-replace-setcurveisloop-by-setcurveisclosed/14488>\
**Category:** Development\
**Created:** [November 8, 2020, 2:26pm UTC](https://discourse.slicer.org/t/markupstomodel-should-we-replace-setcurveisloop-by-setcurveisclosed/14488 "2020-11-08T14:26:51Z")\
**Posts on this page:** 3\
**Page:** 1

<div class="post-metadata">

**Author:** ![chir.set](https://sea2.discourse-cdn.com/flex002/user_avatar/discourse.slicer.org/chir.set/32/66982_2.png) [@chir.set](https://discourse.slicer.org/u/chir.set)\
**Post date:** [November 8, 2020, 2:26pm UTC](https://discourse.slicer.org/t/markupstomodel-should-we-replace-setcurveisloop-by-setcurveisclosed/14488/1 "2020-11-08T14:26:51Z")

</div>

Building MarkupsToModel with Slicer/VTK9 on Linux failed (I’m aware VTK9 build is not yet ready for use).

gcc hinted at using SetCurveIsClosed instead of SetCurveIsLoop in MarkupsToModel/Logic/vtkSlicerMarkupsToModelLogic.cxx. After the substitution, MarkupsToModel builds and is packaged.

Is it the right fix?

Thanks.

---

<div class="post-metadata">

**Author:** ![jamesobutler](https://sea2.discourse-cdn.com/flex002/user_avatar/discourse.slicer.org/jamesobutler/32/7511_2.png) [@jamesobutler](https://discourse.slicer.org/u/jamesobutler)\
**Post date:** [November 8, 2020, 3:20pm UTC](https://discourse.slicer.org/t/markupstomodel-should-we-replace-setcurveisloop-by-setcurveisclosed/14488/2 "2020-11-08T15:20:54Z")

</div>

That seems correct based on recent changes made in Slicer core in [https://github.com/Slicer/Slicer/commit/d51f4218cce131bbbafb9b0f3ba5ef230c87b798](https://github.com/Slicer/Slicer/commit/d51f4218cce131bbbafb9b0f3ba5ef230c87b798)

---

<div class="post-metadata">

**Author:** ![lassoan](https://sea2.discourse-cdn.com/flex002/user_avatar/discourse.slicer.org/lassoan/32/13_2.png) [@lassoan](https://discourse.slicer.org/u/lassoan)\
**Post date:** [November 8, 2020, 5:09pm UTC](https://discourse.slicer.org/t/markupstomodel-should-we-replace-setcurveisloop-by-setcurveisclosed/14488/3 "2020-11-08T17:09:37Z")

</div>

Good point. We should have just deprecated the old method name instead of immediately removing it. I’ve restored the old method names for giving more time for module/extension developers to update their code.