Tomorrow, we will be having our next weekly hangout at 11:00 AM ET until 12:00 PM ET. after the project week meetings. We will be re-using the same meeting link
PR 8842 is ready to be reviewed. The commits will be re-grouped into 2-3 commits to make this easier to review, and a timing test will be added:
It is not clear whether transform reading performance will be impacted by some of the 2D vs 3D checks. It is worth testing whether the transform read time is impacted when trying to read a dense 3D displacement field.
Remaking from the superbuild level often does a lot of work for small changes, due to a not yet understood issue in the VTK cmake system. If you know exactly what changed and you only need to rebuild a certain library you can cd into it and make from there
Remaking from the inner build (Slicer-build/) is not too bad-- that is usually pretty fast and clean.
superbuild cloning doesn’t need history (Steve)
Do we really need to git clone the entire project histories in our superbuild (for VTK, etc.)? We should consider adding --depth 1 to our clone commands.
Maybe there was a reason we haven’t been doing that already – it would be good to hear people’s thoughts.
@pieper According to the CMake documentation for ExternalProject git usage, shallow depth cloning is not supported as we use commit hashes for our external projects. See relevant CMake documentation snippets below:
Using a specific git hash ensures that the main project’s own history is fully traceable to a specific point in the external project’s evolution. If a branch or tag name is used instead, then checking out a specific commit of the main project doesn’t necessarily pin the whole build to a specific point in the life of the external project. The lack of such deterministic behavior makes the main project lose traceability and repeatability.
If GIT_SHALLOW is enabled then GIT_TAG works only with branch names and tags. A commit hash is not allowed.
GIT_SHALLOW <bool>
Added in version 3.6.
When this option is enabled, the git clone operation will be given the --depth 1 option. This performs a shallow clone, which avoids downloading the whole history and instead retrieves just the commit denoted by the GIT_TAG option.