Data Module: column show/hide branch or node is editable

phcerdan · September 5, 2018, 4:42pm

Using a recent Slicer c88b17d38

Is this expected? Thanks

lassoan · September 5, 2018, 4:57pm

This seems to be a bug. Can you give it a try and fix it? I think edit triggers need to be changed. It would be nicer to not show the editable part at all, though.

@cpinter

phcerdan · September 5, 2018, 8:54pm

I would love it, but not much time right now. That’s why I opened an “issue” and not a PR directly.

cpinter · September 6, 2018, 3:34pm

I spent quite a bit of time trying to figure out why the ItemIsEditable flag seems to have no effect in Subject hierarchy, as opposed to the regular qMRMLSceneModel, where it works.

This line is supposed to selectively enable the editable flag which is off by default, I confirmed it with debugging:

github.com

Slicer/Slicer/blob/master/Modules/Loadable/SubjectHierarchy/Widgets/qMRMLSubjectHierarchyModel.cxx#L777




if (!d->SubjectHierarchyNode)
  {
  qCritical() << Q_FUNC_INFO << ": Invalid subject hierarchy";
  return flags;
  }


// Name and transform columns are editable
if (column == this->nameColumn() || column == this->transformColumn())
  {
  flags |= Qt::ItemIsEditable;
  }


if (this->canBeAChild(itemID))
  {
  flags |= Qt::ItemIsDragEnabled;
  }
if (this->canBeAParent(itemID))
  {
  flags |= Qt::ItemIsDropEnabled;
  }

However it doesn’t matter what this flag says, the cell is always editable.

The same thing is happening here, but in this case the editable flag works as expected.

github.com

Slicer/Slicer/blob/master/Libs/MRML/Widgets/qMRMLSceneModel.cxx#L936


QFlags<Qt::ItemFlag> qMRMLSceneModel::nodeFlags(vtkMRMLNode* node, int column)const
{
QFlags<Qt::ItemFlag> flags = Qt::ItemIsEnabled
                           | Qt::ItemIsSelectable;
if (column == this->checkableColumn() && node->GetSelectable())
  {
  flags = flags | Qt::ItemIsUserCheckable;
  }
if (column == this->nameColumn())
  {
  flags = flags | Qt::ItemIsEditable;
  }
if (this->canBeAChild(node))
  {
  flags = flags | Qt::ItemIsDragEnabled;
  }
if (this->canBeAParent(node))
  {
  flags = flags | Qt::ItemIsDropEnabled;
  }

I implemented a workaround to prevent editing of the visibility and ID columns. I committed it, so the symptom you reported doesn’t come up any more. If anybody has any idea about the ItemIsEditable mistery, I’d be glad to hear it.

cpinter · September 6, 2018, 5:05pm

We teamed up with Andras and with some painful Qt debugging we managed to find the reason why the flag was not used properly. I committed the real fix and removed the previous workaround.

phcerdan · September 6, 2018, 6:13pm

Thanks @cpinter @lassoan!

Topic		Replies	Views
qMRMLSubjectHierarchyTreeView Makes a column uneditable Development	3	261	September 3, 2022
Change editortrigger using subjectHierarchyItemFlags() Development	0	61	April 11, 2024
Show type of Node in SubjectHierarchyTreeView Development	4	363	June 8, 2021
API change in SubjectHierarchyNode? Development	6	554	December 15, 2021
Subject hierarchy Development	2	1594	November 12, 2019

Data Module: column show/hide branch or node is editable

Related topics