Is SlicerJupyter broken on macOS due to argon2-cffi (again?)

Sam_Horvath · February 17, 2021, 2:59pm

So:

Changing this line:

jupyter-xeus/xeus/blob/3369bc7f1ced8d85c47a9a069677c8719557bc2e/src/xdap_tcp_client.cpp#L192


    return zmq::message_t(m_socket_id.data<const char>(), m_socket_id.size());
}
void xdap_tcp_client::init_tcp_socket(const std::string& tcp_end_point)
{
    if (m_dap_tcp_type == dap_tcp_type::client)
    {
        m_tcp_socket.connect(tcp_end_point);
        size_t id_size = 256;
        std::string id = m_tcp_socket.get(zmq::sockopt::routing_id, id_size);
        m_socket_id = zmq::message_t(id);
    }
    else
    {
        m_tcp_socket.bind(tcp_end_point);
        (void)m_tcp_socket.recv(m_socket_id);
        zmq::message_t msg;
        (void)m_tcp_socket.recv(msg);
    }
}

to:

m_socket_id = zmq::message_t(id.data(), id.size());

fixes the build error. The breaking change was introduced in SlicerJupyter here:

and in Xeus here:

Why its breaking: not sure. There is a conversion constructor that should handle this:

github.com

zeromq/cppzmq/blob/f428fee37426888532b55da152e99de510c8361a/zmq.hpp#L470


             typename = typename std::enable_if<
               detail::is_range<Range>::value
               && ZMQ_IS_TRIVIALLY_COPYABLE(detail::range_value_t<Range>)
               && !detail::is_char_type<detail::range_value_t<Range>>::value
               && !std::is_same<Range, message_t>::value>::type>
    explicit message_t(const Range &rng) :
        message_t(detail::ranges::begin(rng), detail::ranges::end(rng))
    {
    }
    explicit message_t(const std::string &str) : message_t(str.data(), str.size()) {}
#if CPPZMQ_HAS_STRING_VIEW
    explicit message_t(std::string_view str) : message_t(str.data(), str.size()) {}
#endif
#endif
#ifdef ZMQ_HAS_RVALUE_REFS
    message_t(message_t &&rhs) ZMQ_NOTHROW : msg(rhs.msg)
    {

but it doesn’t seem to be.

Topic		Replies	Views
SlicerJupyter build failed on MacOSX due to failed building wheel for argon2-cffi Support	8	629	September 24, 2021
Slicer/Jupyter integration: installing python packages Support jupyter	29	2526	September 17, 2020
Open3d pip_install error on Mac Support	5	2244	August 5, 2020
Can't load open3d Support	7	1214	August 12, 2020
Installing SlicerJupyter causes Slicer to crash Support	3	263	April 16, 2024

Is SlicerJupyter broken on macOS due to argon2-cffi (again?)

Related topics