Screen capture - 600 frame limit?

[hherhold (Hollister Herhold)]

Is there a reason for the 600 frame limit in the Screen Capture module? (It looks easy enough to change in ScreenCapture.py, I was just wondering if there was a reason for the limit.)

Thanks!

-Hollister

[lassoan (Andras Lasso)]

The only reason for a maximum limit is the slider widget. If the max value of the slider is too high then it is very hard to adjust the slider in small steps. You could add a maximum number of images spinbox in the Advanced section and send a pull request.

[hherhold (Hollister Herhold)]

OK, I’ll give it a go.

Thanks!

[hherhold (Hollister Herhold)]

Done, just submitted pull request. It turned out to be more straightforward than I thought it would be.

[jcfr (Jean Christophe Fillion Robin (Kitware))]

Thanks @hherhold for the pull request

For reference:

Open IGT Link I/F

[jcfr (Jean Christophe Fillion Robin (Kitware))]

To follow up on this, based on the suggestions from @lassoan

@lassoan

The only reason for a maximum limit is the slider widget. If the max value of the slider is too high then it is very hard to adjust the slider in small steps. You could add a maximum number of images spinbox in the Advanced section and send a pull request.

@hherhold contributed the changes and they just got integrated in r26507 . It means, they will be available in tomorrow nightly build available at Download 3D Slicer | 3D Slicer

Well done