Set and observe transform node to markups curve node: bug or feature?

Support
,
1

Greeting,

Transformation of vtkMRMLMarkupsClosedCurveNode looks like a little bit buggy. Points of the curve are transformed correctly, but not the curve itself.

There is no such problem with markups line node, where both line and points are transformed correctly.

Code closedCurveNode->SetAndObserveTransformNodeID(transformNode->GetID());

gives such results

Screenshot_Markups1
Screenshot_Markups1968Ă—610 5.04 KB

Screenshot_Markups2
Screenshot_Markups21000Ă—610 11 KB

2

Thanks for reporting this, I’ll take a look at it.

1 Like
3

@mik Can you reproduce the problem with the latest Slicer Preview Release?

4

Build from the source, the problem remains.

Slicer 4.11.0-2020-05-14 r29057 / 0bc7cb1

curve node without transformation

image
image1686Ă—708 44.8 KB

curve node with transformation (points and curve are separated)

image
image1734Ă—709 45.5 KB

5

I’ve made a fix, could you try the latest version of Slicer?

1 Like
6

The fix will be included in Slicer Preview Release that you download tomorrow or later.

7

Thank you, the major problem has been fixed.

I have one more minor issue with markups node. How to update markups data in loadable module correctly?

I have markups node with four points (rectangle). When i update markups control point position the code the point change it position, but not the curve.

The have found the solution by removing node and creating it with a new positions.

8

Can you send a link to the code lines where you set the control point positions?

9

Here is a method, which creates a curve node, other curve nodes use the same technique.

10

I made the following snippet based on the code from the CreateImagerBoundary function, but it doesn’t seem to cause the issue:

c = slicer.vtkMRMLMarkupsClosedCurveNode()
slicer.mrmlScene.AddNode(c)
c.SetCurveTypeToLinear()
c.SetHideFromEditors(1)
c.AddControlPoint(vtk.vtkVector3d(0.0, 0.0, 0.0))
c.AddControlPoint(vtk.vtkVector3d(1.0, 0.0, 0.0))
c.AddControlPoint(vtk.vtkVector3d(1.0, 1.0, 0.0))
c.AddControlPoint(vtk.vtkVector3d(0.0, 1.0, 0.0))
11

What would happen if you modify a z coordinate of each point and try to update a curve node? Will the curve change it position as well, not just control points?

Static curve is not a problem anymore, thanks to your fix, but in GUI i have a slider which change z coordinates of the curve and only control points move.

12

Updating a control point position updates the curve correctly. For example, this code updates first point of curve “C” correctly (point and curve are both updated):

c = getNode('C')
p = [0,0,0]
c.GetNthControlPointPosition(0, p)
p[2] = p[2] + 10
c.SetNthControlPointPosition(0, *p)
13

Thank you!

After some trials and errors, i have found the code

double p[3];
imagerMarkupsNode->GetNthControlPointPosition( 0, p);
p[2] = value
imagerMarkupsNode->Modified()

didn’t work, but code

double p[3];
imagerMarkupsNode->GetNthControlPointPosition( 0, p);
p[2] = value
imagerMarkupsNode->SetNthControlPointPosition( 0, p[0], p[1], p[2]);

works as it should.

The topic is closed.

1 Like
14

Would you recommend to make any changes to the documentation to clarify that no permanent synchronization mechanism is created between the input Python array and a markups node when you call GetNthControlPointPosition?

15

It will good to have a some kind of warning about such feature, and something like:

Warning: In order to update position of markups as well as a curve, one always must use SetNthControlPointPosition method.