Do you know which is the latest Slicer revision on which VMTK works / how I can figure it out?
mschumaker
(Michael Schumaker)
June 27, 2018, 5:24pm
22
You can look at the build and testing record for Slicer and extensions at http://slicer.cdash.org/viewProjects.php . Open the tools, click Show Filters, and search for the Build Name VMTK. The Slicer4 project uses Qt4.8, and there are successful builds of the VMTK extension there (the Qt5 build is SlicerPreview). The latest ones haven’t built properly because there is a pending pull request at vmtk/SlicerExtension-VMTK that someone needs to review and accept. The last successful build of the extension was on June 13:
http://slicer.cdash.org/index.php?project=Slicer4&date=2018-06-13&filtercount=1&showfilters=1&field1=buildname&compare1=63&value1=VMTK
1 Like
mschumaker
(Michael Schumaker)
June 27, 2018, 6:52pm
23
Here’s where I posted about VTK9 compatibility for VMTK. Feel free to add comments expressing your interest.
https://groups.google.com/forum/#!topic/vmtk-users/rhMaE8W8oi0
opened 08:13PM - 13 Jun 18 UTC
closed 08:47AM - 17 Aug 18 UTC
I'd like to request investigating VTK9 compatibility of VMTK, in anticipation of… their stable release. The reason I'm requesting this is to be able to compile SlicerExtension-VMTK with macOS 10.12 and 10.13, which no longer support Qt4. 3D Slicer has introduced a Qt5-compatible version, but it requires VTK9. I've found that I can compile VMTK with 8.1, but I get a build error when trying it with the same VTK version as my Slicer build:
```
[ 37%] Performing build step for 'VMTK'
[ 0%] Built target nl
[ 1%] Built target vtkvmtkITK
make[5]: *** No rule to make target `/short/testing/SlicerExtension-VMTK-Build/VMTK/vtkVmtk/Utilities/vtkvmtkITK/vtkvmtkITKHierarchy', needed by `vtkVmtk/Utilities/vtkvmtkITK/vtkvmtkITKArchetypeImageSeriesReaderPython.cxx'. Stop.
make[4]: *** [vtkVmtk/Utilities/vtkvmtkITK/CMakeFiles/vtkvmtkITKPythonD.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [VMTK-prefix/src/VMTK-stamp/VMTK-build] Error 2
make[1]: *** [CMakeFiles/VMTK.dir/all] Error 2
make: *** [all] Error 2
```
I've discussed this with @jcfr, and he's found a similar error. He's submitted a pull request that will fix other macOS issues with SlicerExtension-VMTK, but to keep up with current Slicer development, VTK9 compatibility is needed.
1 Like
mschumaker
(Michael Schumaker)
July 5, 2018, 2:46pm
24
I’ve submitted a pull request to the Slicer ExtensionsIndex, so that SlicerVMTK is fetched from vmtk/SlicerExtension-VMTK. At the moment, it’s still trying to fetch from a deleted branch of @jcfr ’s repository, and failing. I don’t have Write permission - could someone review and accept it? Or may I have Write permission?
Slicer:master
← mschumak:Jun12-VMTK-edit
opened 02:48PM - 28 Jun 18 UTC
The remote source for SlicerVMTK.s4ext was previously set to a personal reposito… ry. Fixes have been made in the GitHub.com/vmtk/SlicerExtension-VMTK.git source, and so it can be the source for the extension's code.
This pull request changes the source code manager lines in SlicerVMTK.git to:
scmurl https://github.com/vmtk/SlicerExtension-VMTK
scmrevision master
mschumaker
(Michael Schumaker)
July 9, 2018, 3:15pm
25
I’ve narrowed down what changes in VTK have led to problems compiling VMTK for SlicerPreview. The last VTK9 revision that results in a successful VMTK build was merged into master on Dec 13, 2017: c96fe3bca6bdb7df83252f8a443d8e0428cab956, “Merge branch ‘upstream-expat’ into update-expat”. The commit that follows it deals with vtkWrapHierarchy.
committed 04:31PM - 13 Dec 17 UTC
For two days after that, I can’t get VTK itself to compile, then with revisions from Dec 15 onwards I get the error we’ve been seeing in the recent build attempts. @jcfr , @lassoan , do you have any insight into why that change would cause problems, and how to address it? Thanks for any assistance.
I wrote more about it in the last comments here:
opened 08:13PM - 13 Jun 18 UTC
closed 08:47AM - 17 Aug 18 UTC
I'd like to request investigating VTK9 compatibility of VMTK, in anticipation of… their stable release. The reason I'm requesting this is to be able to compile SlicerExtension-VMTK with macOS 10.12 and 10.13, which no longer support Qt4. 3D Slicer has introduced a Qt5-compatible version, but it requires VTK9. I've found that I can compile VMTK with 8.1, but I get a build error when trying it with the same VTK version as my Slicer build:
```
[ 37%] Performing build step for 'VMTK'
[ 0%] Built target nl
[ 1%] Built target vtkvmtkITK
make[5]: *** No rule to make target `/short/testing/SlicerExtension-VMTK-Build/VMTK/vtkVmtk/Utilities/vtkvmtkITK/vtkvmtkITKHierarchy', needed by `vtkVmtk/Utilities/vtkvmtkITK/vtkvmtkITKArchetypeImageSeriesReaderPython.cxx'. Stop.
make[4]: *** [vtkVmtk/Utilities/vtkvmtkITK/CMakeFiles/vtkvmtkITKPythonD.dir/all] Error 2
make[3]: *** [all] Error 2
make[2]: *** [VMTK-prefix/src/VMTK-stamp/VMTK-build] Error 2
make[1]: *** [CMakeFiles/VMTK.dir/all] Error 2
make: *** [all] Error 2
```
I've discussed this with @jcfr, and he's found a similar error. He's submitted a pull request that will fix other macOS issues with SlicerExtension-VMTK, but to keep up with current Slicer development, VTK9 compatibility is needed.
jcfr
(Jean Christophe Fillion Robin (Kitware))
July 20, 2018, 2:35am
26
Hi Folks,
To follow up with this, the build system of VMTK has been fixed and a PR has been submitted, it is currently waiting to be integrated:
vmtk:master
← jcfr:fix-python-wrapping-with-vtk9
opened 05:41PM - 17 Jul 18 UTC
In the process, we also discovered an issue in conda-build
which has also been fixed in the upstream project:
conda:master
← msarahan:no_include_test_files_drops_test_deps
opened 05:24PM - 19 Jul 18 UTC
addresses https://github.com/vmtk/vmtk/pull/313#issuecomment-406146264
CC @jc… fr
@mschumaker Thanks for your patience
1 Like
mschumaker
(Michael Schumaker)
July 20, 2018, 3:11am
27
@jcfr Thanks so much for pursuing this! I appreciate your efforts.