"All segments" is inconsistent in Segment Editor

I’ve been using scissors with “Apply to all segments” to erase or fill in multiple segments. This works on all visible segments, which is actually not what the check box says, but it is what I want it to do, so it works great and saves me a TON of time.

Erase, however, says “Erase all segments” in the check box, which does do what it says it does, erasing all segments - even not visible ones. This is actually NOT what I want - I’d like to be able to erase on ONLY visible segments, NOT ones that are not visible.

So I guess I have two related issues:

  • Assuming this is what is intended, Scissors should say “Apply to all visible segments”
  • I would be really nice to have an option in Erase to only erase visible segments.

Happy to work on fixing these as desired once a consensus is reached.

Thoughts?

Thanks!!

-Hollister

I did just realize (need more coffee) I can do what I want with Erase by setting Editable area to Inside all visible segments, so I guess the only real issue is the text on the check box in Scissors.

Actually, I take that back - even if a segment isn’t visible, and you set Editable area to Inside all visible segments, Erase still erases all segments (visible or not) if Erase all segments is checked.

Thoughts/ideas?

Yes, combining “Erase”, “Erase all segments” and “Inside all visible segments” works well.

I could easily generate a PR with a change to the “Scissors” label text if this is the only issue.

Just tested this again with a spine segmentation in Slicer 4.13 and “Erase” with settings “Erase all segments” and “Inside visible segments” worked as expected: Visible segments got erased, invisible segments stayed untouched …

OK, I’ll give it another try. Thanks!

Segment Editor is primarily for visual editing, i.e., that you always modify visible segments. If you attempt to paint into a hidden segment then you’ll get a warning popup. So, by default when you edit, you edit what is visible.

We reduced the checkbox text to the minimum to save space (if we added “visible” word then it became much longer than other strings in that column) and keep things simple. The tooltip provides more details:

image

This shortening of the checkbox text and spelling out nuances in the tooltip is consistently used in Scissors, Smoothing, Hollow, and Margin effects.

If you find that this simplification goes too far and it is counterintuitive (despite all our efforts to convey the idea that Segment Editor is for modifying visible content) and misleading for users then please suggest alternative wording that is preferably not longer than the current text (or propose layout changes).

2 Likes

Oops, I had tooltips turned off, my mistake. That wording looks good to me and the shortened checkbox text is clear enough, I think.

@rbumm - I think I figured out my issue, I have multiple overlapping segments, some visible, some not and the distinction of “inside all visible segments” wasn’t capturing the subset of segments that I thought it was. Erase does work as advertised when Editable area is selected as you mentioned.

Thanks all!

1 Like