Custom derived markups to draw a ring : request for review, comments

Development
1

@lassoan @cpinter @pieper @jamesobutler @coreDevs

This custom markups uses a base markups line to draw a ring in 2 modes.

  1. The first control point of the base line is the center of the ring, and the
    line’s length is its radius.
  2. Both control points of the base line lie on the circumference of the ring.
    The line’s length is its diameter.

A couple of points are unclear to me, as commented inline. I wish core developpers could comment on these.

I don’t primarily intend to make a self-contained extension of this work. If you find value in it, I’ll be glad to fix anything upon your instructions, and prepare it for a merge in the markups module eventually. Else, it will be available in my repository.

Regards.

1 Like
2

Thank you for the contribution! I tried to find these questions, but I don’t see and issues or PRs, and I don’t have time to read the whole code. Can you please point us to these questions? Thank you!

I don’t primarily intend to make a self-contained extension of this work.

In my opinion making this repository an extension in the Extension Manager would be the best option. The Markups module contains the most frequently used markups, and the list (and the toolbar) is already quite long. I’d not make it longer by default, and some really useful markups are in extensions too (see this extension for example GitHub - SlicerHeart/SlicerSurfaceMarkup: Extension to test the new grid surface markup with).

3

Hi,

Sorry for the late reply.

That might be the best option, I’m not yet ready for that now.

I updated the code thoroughly, it’s in a better shape now. I’ll get back when I’ll stumble on blocking events.

Thank you for your input.