Mac factory error - "svn: error: Failed to locate 'svn'."

Development
, ,
1

There is an error for the dcmqi extension on the mac factory here: CDash

image

I have a Slicer build on my mac, and I also don’t have svn, but extension build does not fail the same way. Here’s what I get when building locally:

-- Setting default for EXTENSION_STATUS ........:
-- Found Git: /usr/bin/git
-- Could NOT find Subversion (missing: Subversion_SVN_EXECUTABLE)
-- Checking if using built-in JsonCpp
-- Checking if using built-in JsonCpp - no

I then installed svn using brew, and, again, I have no problem with configuring and building the extension:

-- Setting default for EXTENSION_STATUS ........:
-- Found Git: /usr/bin/git
-- Found Subversion: /usr/local/bin/svn (found version "1.14.1")
-- Checking if using built-in JsonCpp
-- Checking if using built-in JsonCpp - no

Is there an issue with how svn is installed on the mac factory? Does anyone know more about this error?

2

May want to check out Simplify build system removing extension build svn support by jcfr · Pull Request #5562 · Slicer/Slicer · GitHub which removes some svn support. Ultimate solution might simply be to remove the old svn support.

1 Like
3

Thanks, although I am not sure this is related. I still think there is something not right with the svn installation on the factory. From the factory error, it seems that there is svn installed, but it does not produce the expected output when run with --version.

If I only knew where svn should be removed in my superbuild! I do not consciously use it my extension, it is inherited somewhere in cmake, and I can’t trace it down.

4

SVN is not installed on that factory machine (it is not the one that build the extensions, it just runs tests).

We debated if we should install SVN on that factory machine or remove SVN support from the build scripts. We chose the latter because nobody uses SVN anymore (none of the 150+ extensions), and removing it allow some simplification in the build scripts.

5

Is there any guidance on what should be done in extensions to adapt to that change?

6

No action needed from extension developers. The extensions are successfully built by factory-south-macos.kitware. For now, just ignore the “SVN not found” error on computron-macos-tests.kitware.

7

I checked again, and those are build errors, not failing tests, see CDash

image

2021-04-03_21-21-03

8

I see, I misunderstood your earlier statement. I will ignore anything coming from computron-macos-tests.kitware. Thank you.

9

Once the SVN issue is sorted, computron-macos-tests.kitware will the be authoritative report for test results for mac.

Background:

I have been working on getting the testing infrastructure cleaned up for Slicer and extensions. Tasks for this include:

  • Re-enabling linux testing [done]
  • Moving mac testing to a separate factory (in progress, and the cause of the current issue)
    • Reason: The mac GUI tests can be pretty fragile, and error / info dialogs that might pop up hold up the entire testing process. While I work on preventing these issues from happening, the tests have been moved so that the build and package process is not interrupted.
  • Fixing windows tests so that we capture the console output
    • Console output is not captured because we are using a non-console launcher for the factory packages. We are planning to create a separate testing launcher w/ console to allow capture of console output.
2 Likes