fedorov
(Andrey Fedorov)
October 24, 2017, 1:55pm
#1
There are new failures in some of the extensions starting from Oct 19 (sorry, I noticed just now). We did not change the extensions code in that period of time, so it must be due to some Slicer changes.
Specifically, DCMQI and PkModeling started to fail (both are superbuild-style extensions).
Last successful dashboard: http://slicer.cdash.org/index.php?project=Slicer4&date=2017-10-17&filtercombine=or&filtercount=2&showfilters=1&filtercombine=or&field1=buildname&compare1=63&value1=DCMQI&field2=buildname&compare2=63&value2=PkModeling
First time they started to fail: http://slicer.cdash.org/index.php?project=Slicer4&date=2017-10-19&filtercount=2&showfilters=1&filtercombine=or&field1=buildname&compare1=63&value1=DCMQI&field2=buildname&compare2=63&value2=PkModeling
Specific errors:
At the same time, the packages appear to be generated.
ihnorton
(Isaiah Norton)
October 24, 2017, 3:35pm
#2
Also seeing this, but only for Mac build (UKFTractography extension).
fedorov
(Andrey Fedorov)
October 24, 2017, 3:51pm
#3
For the extensions I mentioned, it is also only Mac builds.
fedorov
(Andrey Fedorov)
October 25, 2017, 3:33pm
#4
@jcfr I did not test, but on the surface at least (the error happens in the fixup_extension step, the specific failure is about not being able to locate the extension dir, the error happens in the superbuild extensions) it looks like this commit is to blame:
https://github.com/Slicer/Slicer/commit/d6c3a2cf4999c4a3eb5dedd974e1f1aa6fd7aac6
What do you think?
In the latest Windows nightly (4.9.0-2017-10-25) I don’t see any extensions at all. Below is a screenshot of what I see.
jcfr
(Jean Christophe Fillion Robin (Kitware))
October 27, 2017, 6:01pm
#6
fedorov:
I did not test, but on the surface at least (the error happens in the fixup_extension step, the specific failure is about not being able to locate the extension dir, the error happens in the superbuild extensions) it looks like this commit is to blame:
Thanks for the report. If it hasn’t been addressed yet, I will follow up shortly.
1 Like
fedorov
(Andrey Fedorov)
November 4, 2017, 3:30pm
#7
Unfortunately, the build errors are still there.
fedorov
(Andrey Fedorov)
November 4, 2017, 3:31pm
#8
@jcfr what would be the consequences of reverting the commit that introduced the regression?
jcfr
(Jean Christophe Fillion Robin (Kitware))
November 4, 2017, 7:51pm
#9
Tackling this now, we should have fix in shortly.
1 Like
jcfr
(Jean Christophe Fillion Robin (Kitware))
November 4, 2017, 8:05pm
#10
Problem identified. PR for PkModeling and DCMQI on the way
jcfr
(Jean Christophe Fillion Robin (Kitware))
November 4, 2017, 8:51pm
#11
PRs fixing DCMQI and PkModeling have been submitted:
Also, Slicer extension build system has been improved to help extension developer diagnose the problem at configuration time. An configure like the following will now be reported:
NameOfExtension: Variable CPACK_INSTALL_CMAKE_PROJECTS is expected to be set.
https://github.com/Slicer/Slicer/commit/b160ec13f276a86306513954ef8b08a5332afc2e
1 Like
ihnorton
(Isaiah Norton)
November 6, 2017, 3:01pm
#12
Would the value of CPACK_INSTALL_CMAKE_PROJECTS
ever be different than in those PRs?
jcfr
(Jean Christophe Fillion Robin (Kitware))
November 6, 2017, 3:53pm
#13
If the project only includes Slicer modules, it should not be different.
In the case of this PR, we explicitly install the RuntimeLibraries
component. Other more complex project could have other components …