Extension build failures

[fedorov (Andrey Fedorov)]

There are new failures in some of the extensions starting from Oct 19 (sorry, I noticed just now). We did not change the extensions code in that period of time, so it must be due to some Slicer changes.

Specifically, DCMQI and PkModeling started to fail (both are superbuild-style extensions).

Last successful dashboard: CDash

First time they started to fail: CDash

Specific errors:

At the same time, the packages appear to be generated.

[ihnorton (Isaiah Norton)]

Also seeing this, but only for Mac build (UKFTractography extension).

[fedorov (Andrey Fedorov)]

For the extensions I mentioned, it is also only Mac builds.

[fedorov (Andrey Fedorov)]

@jcfr I did not test, but on the surface at least (the error happens in the fixup_extension step, the specific failure is about not being able to locate the extension dir, the error happens in the superbuild extensions) it looks like this commit is to blame:

https://github.com/Slicer/Slicer/commit/d6c3a2cf4999c4a3eb5dedd974e1f1aa6fd7aac6

What do you think?

[markasselin]

In the latest Windows nightly (4.9.0-2017-10-25) I don’t see any extensions at all. Below is a screenshot of what I see.

[jcfr (Jean Christophe Fillion Robin (Kitware))]

@fedorov

I did not test, but on the surface at least (the error happens in the fixup_extension step, the specific failure is about not being able to locate the extension dir, the error happens in the superbuild extensions) it looks like this commit is to blame:

Thanks for the report. If it hasn’t been addressed yet, I will follow up shortly.

[fedorov (Andrey Fedorov)]

Unfortunately, the build errors are still there.

[fedorov (Andrey Fedorov)]

@jcfr what would be the consequences of reverting the commit that introduced the regression?

[jcfr (Jean Christophe Fillion Robin (Kitware))]

Tackling this now, we should have fix in shortly.

[jcfr (Jean Christophe Fillion Robin (Kitware))]

Problem identified. PR for PkModeling and DCMQI on the way

[jcfr (Jean Christophe Fillion Robin (Kitware))]

PRs fixing DCMQI and PkModeling have been submitted:

• https://github.com/QIICR/dcmqi/pull/310
• https://github.com/millerjv/PkModeling/pull/65

Also, Slicer extension build system has been improved to help extension developer diagnose the problem at configuration time. An configure like the following will now be reported:

NameOfExtension: Variable CPACK_INSTALL_CMAKE_PROJECTS is expected to be set.

https://github.com/Slicer/Slicer/commit/b160ec13f276a86306513954ef8b08a5332afc2e

[ihnorton (Isaiah Norton)]

Would the value of CPACK_INSTALL_CMAKE_PROJECTS ever be different than in those PRs?

[jcfr (Jean Christophe Fillion Robin (Kitware))]

@ihnorton

Would the value of CPACK_INSTALL_CMAKE_PROJECTS ever be different than in those PRs?

If the project only includes Slicer modules, it should not be different.

In the case of this PR, we explicitly install the RuntimeLibraries component. Other more complex project could have other components …