Masking: "Overwrite visible" allowing overlap instead of overwriting

[sioussou]

Problem report for Slicer 4.11.20200930 win-amd64: in segment editor, I’ve set the masking option “Modify other segments” to “Overwrite visible” before applying smoothing [closing (fill holes) - 1.00mm]. If any of my segments is then hidden before applying the effect, the visible segments end up overlapping instead of one overwriting the other as expected.

Confirmed that performing the analogous operation in Slicer 4.10.2 (same volume, segmentation, “Overwrite other segments” set to “Visible segments”) results in expected overwriting behavior.

Is this a bug or did the functionality of this masking option change? If it changed, is there still a way to cause an effect to overwrite visible segments as in 4.10.2?

Thanks!

[muratmaga]

I can’t reproduce this:
This is what I did: created yellow and green segments, and then hid the yellow and create the brown segment using the overwrite to visible segments. As expect it overwrote the green but, overlapped with yellow since it was hidden at the time.

Is this not the behavior you expect?

[lassoan (Andras Lasso)]

@sioussou

Problem report for Slicer 4.11.20200930 win-amd64: in segment editor, I’ve set the masking option “Modify other segments” to “Overwrite visible” before applying smoothing [closing (fill holes) - 1.00mm]. If any of my segments is then hidden before applying the effect, the visible segments end up overlapping instead of one overwriting the other as expected

This is the correct behavior. “Overwrite visible” means that only visible segments are overwritten.

[sioussou]

@muratmaga

This is what I did: created yellow and green segments, and then hid the yellow and create the brown segment using the overwrite to visible segments. As expect it overwrote the green but, overlapped with yellow since it was hidden at the time.

Confirming that if I follow the procedure you’ve described I reproduce the same results and this is the behavior I expect.

However, the problem I’m seeing occurs under slightly different circumstances:

1. Create green, yellow, and brown segments
   
   
2. Hide brown segment
3. Switch “Modify other segments” to Overwrite visible
4. Apply smoothing [closing (fill holes) - 3.0mm] to yellow
   
   

Since yellow and green are visible, I’m expecting the smoothing effect on yellow to overwrite parts of green; instead they end up overlapping, which can be further confirmed by hiding the yellow layer.

[muratmaga]

Himm, this looks like a bug, perhaps @lassoan can comment. Meanwhile if you need to make progress, you can subtract yellow from green using logical operators to get what you need.

[lassoan (Andras Lasso)]

@Sunderlandkyl has fixed this recently. The problem is not reproducible in Slicer Preview Release.

[sioussou]

@lassoan

@Sunderlandkyl has fixed this recently. The problem is not reproducible in Slicer Preview Release.

Conducted the test from my previous post in the most recent Slicer Preview Release (Slicer 4.13.0-2020-12-07 win-amd64) and the issue is still present

[jamesobutler (James Butler)]

I was able to replicate using Slicer 4.13.0-2020-12-07 as well. There is different behavior if Segment_3 is hidden or shown when applying “Closing (fill holes)” smoothing to the selected visible Segment_2.

1. My 3 segments originally applied with default “Overwrite all”.
   
   
2. Segment_3 remains visible and applying “Closing (fill holes)” for Segment_2 with “Overwrite visible”. Segment_2 is filled in correctly and also correctly overwrites Segment_1.
   
   
3. Undo that last action and instead hide Segment_3 and then select Segment_2 again and applying “Closing (fill holes)” for Segment_2 with “Overwrite visible”. Segment_2 new area from smoothing is overlapping Segment_1 instead of overwriting.
   
   

[lassoan (Andras Lasso)]

Thanks a lot, based on your description I was able to reproduce this behavior and it is indeed incorrect. I’ve filed a bug report for it:

Segment Editor "overwrite visible segments" mode sometimes allow overlap