Support --designer launcher argument for Qt5 build

cpinter · January 23, 2018, 5:39pm

The --designer launcher switch doesn’t work with Qt5 builds. It seems that it’s because the variable checked at this line is empty:

github.com

Slicer/Slicer/blob/master/CMake/SlicerMacroBuildApplication.cmake#L543


# Configure Launcher
# --------------------------------------------------------------------------
if(SLICERAPP_CONFIGURE_LAUNCHER)
  if(Slicer_USE_CTKAPPLAUNCHER)


    find_package(CTKAppLauncher REQUIRED)


    # Define list of extra 'application to launch' to associate with the launcher
    # within the build tree
    set(extraApplicationToLaunchListForBuildTree)


    if(${Slicer_REQUIRED_QT_VERSION} VERSION_GREATER_EQUAL 5 AND NOT QT_DESIGNER_EXECUTABLE)
      # Since Qt only provides a CMake module to find the designer library, we work
      # around this limitation by finding the designer executable.
      find_program(QT_DESIGNER_EXECUTABLE designer Designer "${QT_BINARY_DIR}")
    endif()


    if(EXISTS ${QT_DESIGNER_EXECUTABLE})
      ctkAppLauncherAppendExtraAppToLaunchToList(
        LONG_ARG designer
        HELP "Start Qt designer using Slicer plugins"

It would be great if this variable was set for Qt5 automatically. Any ideas how to make that happen?

jcfr · January 24, 2018, 12:03am

Thanks to a PR of @adamrankin and inputs from @msmolens and @ihnorton , this is now fixed by 26856 and 26859

jcfr · December 6, 2018, 5:57am

Commit r27608 fixes the lookup of the designer executable ensuring the one associated with the Qt5 version being is used is found.

Topic		Replies	Views
How to start Qt designer in Slicer environment from Ubuntu 20.04? Support	5	801	September 18, 2020
How to load with CTKWidgets and qMRMLWidgets Development	2	426	February 25, 2019
Designer will not load with slicer widgets Development	4	432	January 26, 2019
Build failing in CTK on MacOS 10.12, Slicer nightly, Qt 5.9 Development build	23	1964	April 13, 2018
Static build of Qt5 to update the application launcher and support interactive process Development	16	3947	October 13, 2018

Support --designer launcher argument for Qt5 build

Related topics