When using the Markups module and looking at icons to determine functionality, I have observed that there seems to be different visual representations of a “control point”. These different visual representations make it seem like the buttons act on/utilize different objects when in fact they act on/utilize the same type of objects (control points).
Starburst Glyph representation
Sphere3D Glyph representation
Square blue outline Glyph representation
It would be helpful if an icon is referring to a Markups “control point” that they all use the same visual representation. This applies even to module icon like the Markups module because it is using control points in the icon.
If these icons are updated, should the control point visualization match the Slicer default display of control points? Do the Slicer defaults need to be updated? Current defaults are below:
Glyph: Sphere3D
Color: #ff8080
My guess is that Starburst2D used to be the default glyph and it was changed at some point for some reason? This resulting in the split of various representations in the icons.
I believe there was also previous discussion about making the default control point color match the color in the icon. Therefore it should either be the more salmon color as in the Starburst2D representations, or the more deep red color as in the Sphere3D representations.
Agreed, it would be nice to harmonize these icons.
I find that crosshair with a dot is very good for accurate positioning in slice views, while in 3D usually the sphere glyph looks the most natural. The sphere glyph is usually good enough in slice views as well, so keeping the current sphere glyph as default - and use that in all the markups module icons - makes sense.
To have crisp icons at all resolutions, we would need create SVGs that are pixel-perfect at the size of 24x24 pixels, using colors that work over both light and dark background (just to avoid the need of dynamically recoloring/replacing icons when switching between light/dark mode), preferably in Inkscape.
Kitware designers (Steve Jordan) offered their help for this. If we put together a small set of well-described icons (name, description, previous appearance) then he can design them. Markups icons could be a good collection - not too many, closely related icons that would greatly benefit from a redesign.
I find that anything other than a sphere seems odd in the 3D views. I think either cross-hair with a dot or a circle works OK in 2D. I like being able to see more of the image with the cross-hair, but it’s also helpful that the representation is similar between the 2D and 3D views for the circle/sphere. Overall, I would vote for the circle/sphere pairing as the default (and what’s shown on icons). One option would be to use a cross-hair when placing new control points, and a circle/sphere for placed points. I’m not sure how well that functionality would fit into how markups work under the hood, though, so maybe it’s not very feasible.
