Build failure on Ubuntu

Development
1

Just did and update and tried to rebuild Slicer. I get the error:

loading initial cache file /home/lorensen/ProjectsGIT/Slicer-Superbuild/zlib-prefix/tmp/zlib-cache-Release.cmake
CMake Error at CMakeLists.txt:3 (PROJECT):
Generator

Unix Makefiles

does not support toolset specification, but toolset

USES_TERMINAL_DOWNLOAD

was specified.

– Configuring incomplete, errors occurred!
See also “/home/lorensen/ProjectsGIT/Slicer-Superbuild/zlib-build/CMakeFiles/CMakeOutput.log”.

2

I did a fresh build on ubuntu with make -j20 and got an error that had scrolled off. When I did a second build it completed with no error. I’ll try another fresh build into a log file and see if it’s the same issue you reported.

3

Clean build, same error.

4

got bisect says it was this commit that broke the build:
[7cafe8c8bc9be7128ffd3179a734a98850539af9] ENH: Update ExternalProjectDependency based on commontk/Artichoke@5ee3d50

5

@jcfr looks like your commit:

commit 7cafe8c8bc9be7128ffd3179a734a98850539af9
Author: jcfr jcfr@3bd1e089-480b-0410-8dfb-8563597acbee
Date: Fri Apr 14 22:24:36 2017 +0000

ENH: Update ExternalProjectDependency based on commontk/Artichoke@5ee3d50

This commit improves the support for Ninja generator by ensuring the
option USES_TERMINAL_* options are set to give Ninja access to the
terminal when the CMake version supports it.

See https://cmake.org/cmake/help/v3.4/module/ExternalProject.html

Also Update CTK to integrate a similar update:

$ git shortlog 19fc678..b8587e5 --no-merges
Jean-Christophe Fillion-Robin (2):
      Update ExternalProjectDependency based on commontk/Artichoke@5ee3d50
      ENH: ExternalProjecDependency: Re-apply commontk/CTK@6cc426b

git-svn-id: http://svn.slicer.org/Slicer4/trunk@25929 3bd1e089-480b-0410-8df
6

@jcfr
Interesting, I’m using cmake version 3.3.2 and the test to use the new USES_TERMINAL_* says:
if(CMAKE_VERSION VERSION_GREATER “3.3”)
# USES_TERMINAL_* options were introduced in CMake 3.4

Looks like the test is wrong.

7

Another clean build completed without error. Probably a race condition.

IMy cmake is 3.5.1 so I didn’t see the TERMINAL issue.

8

In Slicer/CMake/ExternalProjectDependency.cmake

Test should be:
if(CMAKE_VERSION VERSION_GREATER “3.3.2”)
NOT
if(CMAKE_VERSION VERSION_GREATER “3.3”)

9

The same error exists in CTK. I will update my cmake, but I think this error should be fixed.

Bill

10

Thanks for the note. I will update the CMake modules now.

11

https://github.com/commontk/Artichoke/pull/18

12

As soon CI returns green, I will update CTK and Slicer.

Change integrated in Slicer in r25978