MarkupsToModel : should we replace SetCurveIsLoop by SetCurveIsClosed?

Development
1

Building MarkupsToModel with Slicer/VTK9 on Linux failed (I’m aware VTK9 build is not yet ready for use).

gcc hinted at using SetCurveIsClosed instead of SetCurveIsLoop in MarkupsToModel/Logic/vtkSlicerMarkupsToModelLogic.cxx. After the substitution, MarkupsToModel builds and is packaged.

Is it the right fix?

Thanks.

2

That seems correct based on recent changes made in Slicer core in https://github.com/Slicer/Slicer/commit/d51f4218cce131bbbafb9b0f3ba5ef230c87b798

1 Like
3

Good point. We should have just deprecated the old method name instead of immediately removing it. I’ve restored the old method names for giving more time for module/extension developers to update their code.