MarkupsToModel : should we replace SetCurveIsLoop by SetCurveIsClosed?

Building MarkupsToModel with Slicer/VTK9 on Linux failed (I’m aware VTK9 build is not yet ready for use).

gcc hinted at using SetCurveIsClosed instead of SetCurveIsLoop in MarkupsToModel/Logic/vtkSlicerMarkupsToModelLogic.cxx. After the substitution, MarkupsToModel builds and is packaged.

Is it the right fix?


That seems correct based on recent changes made in Slicer core in

1 Like

Good point. We should have just deprecated the old method name instead of immediately removing it. I’ve restored the old method names for giving more time for module/extension developers to update their code.