Master with Qt5 build fails

adamrankin · January 15, 2018, 9:11pm

Cloned Slicer master (b748b88cefa57bc126f3a5c64a4fb59c28e4bb9b) and tried to build with Qt 5.9.1.

Received many generation errors similar to:

  CMake Error at Libs/vtkAddon/CMakeLists.txt:94 (add_library):
    Cannot find source file:

      C:/d/Slcr/S4D/Slicer-build/Libs/vtkAddon/vtkAddonHierarchy.stamp.txt

    Tried extensions .c .C .c++ .cc .cpp .cxx .m .M .mm .h .hh .h++ .hm .hpp
    .hxx .in .txx

Has anyone else experienced this?

Edit: not suprising, but build errors follow on the form:

CUSTOMBUILD : CMake error : CMake can not determine linker language for target: vtkAddon [C:\d\Slcr\S4D\Slicer.vcxproj]

jcfr · January 15, 2018, 10:27pm

Most likely related to the VTKv9 update.

I submitted issue 17217 to upstream VTK project and proposed a fix in MR vtk/vtk#3794 (already added to Slicer fork of VTK).

This addressed issues I experienced on Linux.

Look like there are still some issues.

Here are some related references that will be helpful to debug:

github.com

Slicer/Slicer/blob/b748b88cefa57bc126f3a5c64a4fb59c28e4bb9b/Libs/vtkAddon/CMakeLists.txt#L146-L151


vtkMacroKitPythonWrap(
  KIT_NAME ${lib_name}
  KIT_SRCS ${vtkAddon_SRCS}
  KIT_INSTALL_BIN_DIR ${${PROJECT_NAME}_INSTALL_BIN_DIR}
  KIT_INSTALL_LIB_DIR ${${PROJECT_NAME}_INSTALL_LIB_DIR}
  )

github.com

Slicer/Slicer/blob/b748b88cefa57bc126f3a5c64a4fb59c28e4bb9b/CMake/vtkMacroKitPythonWrap.cmake#L121-L138


include(${VTK_CMAKE_DIR}/vtkWrapHierarchy.cmake)


# Set variables for this and future runs of vtk_wrap_hierarchy:
#  - <module_name>_WRAP_DEPENDS
#  - <module_name>_WRAP_HIERARCHY_FILE
set(${MY_KIT_NAME}_WRAP_DEPENDS "${_kit_wrap_depends}" CACHE INTERNAL "${MY_KIT_NAME} wrapping dependencies" FORCE)
set(_wrap_hierarchy_file "${Slicer_BINARY_DIR}/${MY_KIT_NAME}Hierarchy.txt")
set(_wrap_hierarchy_stamp_file ${CMAKE_CURRENT_BINARY_DIR}/${MY_KIT_NAME}Hierarchy.stamp.txt)
set(${MY_KIT_NAME}_WRAP_HIERARCHY_FILE "${_wrap_hierarchy_file}" CACHE INTERNAL "${MY_KIT_NAME} wrap hierarchy file" FORCE)


set_property(GLOBAL APPEND PROPERTY SLICER_WRAP_HIERARCHY_TARGETS ${MY_KIT_NAME})


# Set variables for vtk_wrap_python3:
#   - KIT_HIERARCHY_FILE
set(KIT_HIERARCHY_FILE "${_wrap_hierarchy_file}")


# Generate hierarchy files
vtk_wrap_hierarchy(${MY_KIT_NAME} ${Slicer_BINARY_DIR} "${TMP_WRAP_FILES}")

github.com

Slicer/VTK/blob/slicer-v9.0.0-2018-01-11-590b341/CMake/vtkWrapHierarchy.cmake

#
# a cmake macro to generate a text file with the class hierarchy
#
macro(VTK_WRAP_HIERARCHY module_name OUTPUT_DIR SOURCES)
  if(NOT VTK_WRAP_HIERARCHY_EXE)
    if(TARGET vtkWrapHierarchy)
      set(VTK_WRAP_HIERARCHY_EXE vtkWrapHierarchy)
    else()
      message(SEND_ERROR "VTK_WRAP_HIERARCHY_EXE not specified when calling VTK_WRAP_HIERARCHY")
    endif()
  endif()

  # collect the common wrapper-tool arguments
  if(NOT VTK_ENABLE_KITS)
    # write wrapper-tool arguments to a file
    set(_args_file ${module_name}Hierarchy.$<CONFIGURATION>.args)
    file(GENERATE OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/${_args_file} CONTENT "
$<$<BOOL:$<TARGET_PROPERTY:${module_name},COMPILE_DEFINITIONS>>:
-D\"$<JOIN:$<TARGET_PROPERTY:${module_name},COMPILE_DEFINITIONS>,\"
-D\">\">

This file has been truncated. show original

jcfr · January 15, 2018, 10:32pm

It turns out that the hierarchy stamp file has been removed in latest VTK:

This means the following Slicer file would have to be updated accordingly:

https://github.com/Slicer/Slicer/blob/b748b88cefa57bc126f3a5c64a4fb59c28e4bb9b/CMake/vtkMacroKitPythonWrap.cmake#L149-L154

jcfr · January 16, 2018, 12:47pm

Thanks for the patch @adamrankin

For future reference:

It has been integrated in r26834

Topic		Replies	Views
Build Slicer Failed with VTK9 Wrapper Error Development	4	315	December 28, 2022
CMake Error at CMake/SlicerBlockFindQtAndCheckVersion Development	2	274	December 16, 2021
I can't build Slicer master branch in Windows10 via VisualStudio2019(toolset v142),Qt5.15.2 Support build , qt	2	305	September 26, 2021
FYI : small patch to build Slicer on Arch Linux Development	3	244	June 20, 2022
Build Error PythonQt Visual Studio 2015 Qt 5.9.2 Development qt	18	2299	November 10, 2017

Master with Qt5 build fails

Related topics